Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cleanup): remove unnecessary async/await #778

Merged
merged 1 commit into from Sep 3, 2020
Merged

fix(cleanup): remove unnecessary async/await #778

merged 1 commit into from Sep 3, 2020

Conversation

ljosberinn
Copy link
Contributor

What:
removed async/await on cleanup afterEach

Why:

no longer needed due to 11.0

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ddf8b7:

Sandbox Source
React Configuration
kentcdodds/react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #778 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #778   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          109       109           
  Branches        16        16           
=========================================
  Hits           109       109           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20acad3...2ddf8b7. Read the comment docs.

@eps1lon eps1lon added the bug Something isn't working label Sep 3, 2020
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon changed the title fix: remove unnecessary async/await fix(cleanup): remove unnecessary async/await Sep 3, 2020
@eps1lon eps1lon merged commit 220d8d4 into testing-library:master Sep 3, 2020
@eps1lon
Copy link
Member

eps1lon commented Sep 3, 2020

@all-contributors add @ljosberinn for code

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @ljosberinn! 🎉

@testing-library-bot
Copy link

🎉 This PR is included in version 11.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ljosberinn ljosberinn deleted the fix/drop-async-await-on-cleanup-aftereach branch September 3, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants