Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add missing characters in complex example #404

Merged
merged 1 commit into from Jul 14, 2019
Merged

docs: Add missing characters in complex example #404

merged 1 commit into from Jul 14, 2019

Conversation

LiaoJimmy
Copy link
Contributor

What:

There are some typos in Complex Example code.

Why:

Example code should be correct.

How:

Change the method name and variable name.

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

kentcdodds
kentcdodds approved these changes Jul 14, 2019
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit b1e5b3a into testing-library:master Jul 14, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @LiaoJimmy for docs

@allcontributors allcontributors bot mentioned this pull request Jul 14, 2019
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @LiaoJimmy! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 8.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LiaoJimmy @kentcdodds