Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run release from 12.x branch #1044

Merged
merged 1 commit into from Apr 11, 2022
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 11, 2022

Recent 12.x merge did not run GitHub actions.

I'm not following the current pattern for release branches so I just simplified it following the Filter pattern cheat sheet.

Comfirmed to work in https://github.com/eps1lon/react-testing-library/actions/runs/2150862258

dom-testing-library has the same pattern and we probably need to port that fix over there to prevent it spreading.

@@ -58,8 +60,7 @@ jobs:
runs-on: ubuntu-latest
if:
${{ github.repository == 'testing-library/react-testing-library' &&
contains('refs/heads/main,refs/heads/beta,refs/heads/next,refs/heads/alpha',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got introduced in testing-library/dom-testing-library#809 but at that point we didn't have a a filter in on.push.branches so this seems redundant now.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c9943a0:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@eps1lon eps1lon marked this pull request as ready for review April 11, 2022 20:04
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (12.x@9e2b5db). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             12.x     #1044   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         4           
  Lines           ?       142           
  Branches        ?        28           
========================================
  Hits            ?       142           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e2b5db...c9943a0. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wondered about this 😅 Thanks!

@kentcdodds kentcdodds merged commit 646129b into testing-library:12.x Apr 11, 2022
@kentcdodds
Copy link
Member

Should probably cherry-pick this into main

@github-actions
Copy link

🎉 This PR is included in version 12.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants