Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix toBeDisabled for TouchableNativeFeedback #53

Conversation

philipbulley
Copy link
Contributor

What:

TouchableNativeFeedback wasn't included in the list of components that have a disabled prop. As such, toBeDisabled would always return false.

Why:

Because Android is important too πŸ˜„

How:

Simply added TouchableNativeFeedback to the allow list of components.

Checklist:

  • Documentation added to the
    docs β€” N/A
  • Typescript definitions updated β€” N/A
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #53 (3856396) into master (db65dfb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines           96        96           
  Branches        28        28           
=========================================
  Hits            96        96           
Impacted Files Coverage Ξ”
src/to-be-disabled.js 100.00% <ΓΈ> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update db65dfb...47af129. Read the comment docs.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@philipbulley
Copy link
Contributor Author

@thymikee thanks for the approval, looks all good with master merged in. Should be ready to merge πŸ™‚

@thymikee thymikee merged commit b45040d into testing-library:master Mar 3, 2021
@bcarroll22
Copy link
Collaborator

πŸŽ‰ This PR is included in version 4.0.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants