Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add validate workflow instead of travis #311

Merged
merged 6 commits into from Nov 29, 2020

Conversation

MatanBobi
Copy link
Member

What:

Add validate workflow by using yo kcd-oss

Why:

Because travis no more

How:

using yo kcd-oss

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged

I guess we can reduce the number of node versions in the metrics, but I kept it as is for now..

@MatanBobi MatanBobi changed the title Pr/add validate workflow ci: Add validate workflow instead of travis Nov 25, 2020
@MatanBobi
Copy link
Member Author

Looks like it failed on snapshots that actually passed on my local env.. any ideas?

other/CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #311 (8a566be) into master (8298015) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #311    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           23        23            
  Lines          315       533   +218     
  Branches        72       194   +122     
==========================================
+ Hits           315       533   +218     
Impacted Files Coverage Δ
src/utils.js 100.00% <0.00%> (ø)
src/to-be-empty.js 100.00% <0.00%> (ø)
src/to-be-checked.js 100.00% <0.00%> (ø)
src/to-be-invalid.js 100.00% <0.00%> (ø)
src/to-be-visible.js 100.00% <0.00%> (ø)
src/to-have-class.js 100.00% <0.00%> (ø)
src/to-have-focus.js 100.00% <0.00%> (ø)
src/to-have-style.js 100.00% <0.00%> (ø)
src/to-have-value.js 100.00% <0.00%> (ø)
src/to-be-disabled.js 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8298015...8a566be. Read the comment docs.

@nickmccurdy
Copy link
Member

Looks like it failed on snapshots that actually passed on my local env.. any ideas?

Fixed, we were missing the FORCE_COLOR environment variable from the Travis config.

@MatanBobi
Copy link
Member Author

MatanBobi commented Nov 26, 2020

Fixed, we were missing the FORCE_COLOR environment variable from the Travis config.

Thanks @nickmccurdy! missed that..

@nickmccurdy nickmccurdy merged commit 2927c95 into master Nov 29, 2020
@nickmccurdy nickmccurdy deleted the pr/add-validate-workflow branch November 29, 2020 04:59
@github-actions
Copy link

🎉 This PR is included in version 5.11.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants