Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note about toBeDisabled not supporting aria-disabled #303

Merged
merged 1 commit into from Oct 23, 2020

Conversation

gnapse
Copy link
Member

@gnapse gnapse commented Oct 22, 2020

What:

Title says it all.

Why:

See #144. The motivation comes from how often this was brought up again after that initial issue (see also #230 and #302).

Checklist:

N/A

@gnapse gnapse requested a review from eps1lon October 22, 2020 22:10
@gnapse gnapse self-assigned this Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #303   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          315       315           
  Branches        72        72           
=========================================
  Hits           315       315           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e460611...c3b2098. Read the comment docs.

@gnapse gnapse merged commit c11f9c5 into master Oct 23, 2020
@gnapse gnapse deleted the aria-disabled-readme-note branch October 23, 2020 12:18
@gnapse
Copy link
Member Author

gnapse commented Oct 23, 2020

🎉 This PR is included in version 5.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant