Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): Remove duplicate "data-testid" from example #291

Merged
merged 1 commit into from Sep 8, 2020

Conversation

danawoodman
Copy link
Contributor

@danawoodman danawoodman commented Sep 8, 2020

What:

Remove duplicate "data-testid" in the readme.

Why:

Having two "data-testid" attributes is invalid, so I assume this is a typo/leftover. Removing should simplify example and prevent possible confusion.

How:

Self explanatory 馃槅

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged

Having two "data-testid" attributes is invalid, so I assume this is a typo/leftover. Removing should simplify example and prevent possible confusion.
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #291   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          315       315           
  Branches        72        72           
=========================================
  Hits           315       315           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2da8c71...108d3be. Read the comment docs.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon changed the title Remove duplicate "data-testid" from example docs(readme): Remove duplicate "data-testid" from example Sep 8, 2020
@eps1lon eps1lon merged commit 0139b9f into testing-library:master Sep 8, 2020
@eps1lon
Copy link
Member

eps1lon commented Sep 8, 2020

@all-contributors add @danawoodman for docs

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @danawoodman! 馃帀

@gnapse
Copy link
Member

gnapse commented Oct 23, 2020

馃帀 This PR is included in version 5.11.5 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants