Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update css dependency to latest version #270

Merged
merged 1 commit into from Jul 2, 2020
Merged

build: update css dependency to latest version #270

merged 1 commit into from Jul 2, 2020

Conversation

kboedges
Copy link
Contributor

@kboedges kboedges commented Jul 2, 2020

What:

Updating the css dependency to the latest version, which no longer depends on urix, a deprecated package: https://github.com/lydell/urix

Why:

Removes a yarn/npm warning I've been seeing on install:

warning @testing-library/jest-dom > css > urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
warning @testing-library/jest-dom > css > source-map-resolve > urix@0.1.0: Please see https://github.com/lydell/urix#deprecated

How:

Changed to latest (3.0.0) in package.json

Checklist:

  • Documentation N/A
  • Tests
  • Updated Type Definitions N/A
  • Ready to be merged

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #270   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          320       320           
  Branches        71        71           
=========================================
  Hits           320       320           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2bb8a...5cb3821. Read the comment docs.

@nickmccurdy nickmccurdy merged commit 0b2c57e into testing-library:master Jul 2, 2020
@nickmccurdy
Copy link
Member

Thanks for the fix!

@nickmccurdy
Copy link
Member

@all-contributors add @kboedges for infra

@allcontributors
Copy link
Contributor

@nickmccurdy

I've put up a pull request to add @kboedges! 🎉

@gnapse
Copy link
Member

gnapse commented Jul 15, 2020

🎉 This PR is included in version 5.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kboedges kboedges deleted the pr/update-css-dependency branch July 15, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants