Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix smoke test's npm setup #714

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

AriPerkkio
Copy link
Contributor

Checks

Changes

  • chore(dev-deps): update eslint-remote-tester-repositories
    • Updates eslint-remote-tester-repositories to new major version. No breaking changes. API is now considered as stable
  • ci: fix smoke test's npm setup
    • Workflow seemed to be crashing due to some Node/NPM setup issues. Copied setup steps from pipeline.yml

.github/workflows/smoke-test.yml Outdated Show resolved Hide resolved
@Belco90 Belco90 merged commit 98cb755 into testing-library:main Jan 5, 2023
@Belco90
Copy link
Member

Belco90 commented Jan 5, 2023

Thanks @AriPerkkio!!

@AriPerkkio AriPerkkio deleted the test/smoke-test-fix branch January 5, 2023 18:05
@github-actions
Copy link

🎉 This PR is included in version 5.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

🎉 This PR is included in version 6.0.0-alpha.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants