Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prefer-find-by): Autofix takes wait query's options into account #679

Merged
merged 2 commits into from Oct 21, 2022
Merged

fix(prefer-find-by): Autofix takes wait query's options into account #679

merged 2 commits into from Oct 21, 2022

Conversation

sjarva
Copy link
Collaborator

@sjarva sjarva commented Oct 20, 2022 •
edited

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • change autofixer to keep wait query's second argument (options), previously this was lost in autofixing
  • fixing documentation formatting (code keywords and a dot)

Context

Solves half (part/scenario 1) of the issue #579

@sjarva sjarva requested a review from Belco90 October 20, 2022 17:45
@sjarva sjarva mentioned this pull request Oct 20, 2022
Open
@Belco90 Belco90 linked an issue Oct 20, 2022 that may be closed by this pull request
prefer-find-by autofix doesn't respect extra code #579
Open
Belco90
Belco90 approved these changes Oct 21, 2022
View reviewed changes
docs/rules/prefer-find-by.md Show resolved Hide resolved
tests/lib/rules/prefer-find-by.test.ts Show resolved Hide resolved
@Belco90 Belco90 merged commit e31fe03 into main Oct 21, 2022
@Belco90 Belco90 deleted the pr/prefer-find-by-bug branch October 21, 2022 12:00
@github-actions
Copy link

🎉 This PR is included in version 5.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 6.0.0-alpha.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prefer-find-by autofix doesn't respect extra code
3 participants
@sjarva @Belco90 @MichaelDeBoey