fix: no-await-sync-events false positive
#641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if delay is declared or assigned a value elsewhere than in the call expression's arguments. Add test cases that have declarations and assignments. Ref: testing-library#403
|
Oh wow, that must have been the fastest review in my life @Belco90 🥳 🎈 Thank you so much! |
|
It was a coincidence to be honest! I opened GitHub to check something else, and I saw this short PR 🚀 |
|
🎉 This PR is included in version 5.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
With |
It won't be removed yet, but we planned to adapt another rule to handle async user event method properly #626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
npm run generate:rules-list)npm run generate:configs)Changes
delayis declared or assigned a value elsewhere than in the call expression's argumentsContext
Closes #403