-
Notifications
You must be signed in to change notification settings - Fork 148
feat(no-await-sync-events): add eventModules option #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM (if the test cases are passing).
Does this also take the setup
into account?
Because with v14, it isn't recommended to directly use userEvents from the imported object, but you should rather create your own userEvent instance.
https://testing-library.com/docs/user-event/setup#starting-a-session-per-setup
That's a good point. It's not addressed in this PR, but we should update all the internal detection helpers to consider this new way of setting up the user-event module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checks
Changes
eventModules
option to be able to disable reporting "fire-event" or "user-event"Context
Closes #567