[await-async-utils] false positive promise all

[Mikeysauce]

Hello,

Take the following example:

await Promise.all([
    waitFor(() =>
      expect(getByText('first-item')).toBeTruthy()
    ),
    waitFor(() =>
      expect(getByText('second-item')).toBeTruthy()
    ),
  ]);

This is flagged up as an error: "Promise returned from waitFor must be handled", which I believe is a false positive, as the Promise is indeed being handled by the Promise.all.

Thanks

[gndelia]

Hi Mikey!
If you are waiting for of those two to appear, perhaps you could consider findByText as an alternative

await Promise.all([findByText('first-item'), findByText('second-item')])

As of the code itself, yeah it sounds like a bug

Thanks for opening the ticket!

[Mikeysauce]

Thanks gndelia,

I'm in agreement with you regarding findBy being more suitable here with it having a built in waitFor behaviour, but some colleagues find the intent of waitFor to be more explicit and so here we are unfortunately. I appreciate the quick reply!

[Belco90]

🎉 This issue has been resolved in version 3.9.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀