Skip to content

feat: add allowed roles to role query types #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 2, 2020
Merged

feat: add allowed roles to role query types #670

merged 4 commits into from
Jul 2, 2020
+196 −125

Conversation

timdeschryver
Copy link
Member

What:

Why:

  • shorten the feedback loop for a better developer experience

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@eps1lon is there already a aria roles union type available that could be reused?

Sorry, something went wrong.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 24, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9fc4f91:

Sandbox Source
nostalgic-hodgkin-qxdz7 Configuration

@codecov
Copy link

codecov bot commented Jun 24, 2020 •
edited
Loading

Codecov Report

Merging #670 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #670   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          603       603           
  Branches       151       151           
=========================================
  Hits           603       603

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639294c...9fc4f91. Read the comment docs.

kentcdodds
kentcdodds reviewed Jun 24, 2020
View reviewed changes
@timdeschryver timdeschryver force-pushed the pr/allowedroles-getbyrole branch 3 times, most recently from 951b539 to ed48005 Compare June 29, 2020 08:32
eps1lon
eps1lon requested changes Jun 29, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor question though.

@timdeschryver timdeschryver force-pushed the pr/allowedroles-getbyrole branch from dc77621 to bce30bf Compare June 29, 2020 18:13
@kentcdodds
Copy link
Member

Seems legit. Looks like travis is failing due to some linting issues in the types?

@timdeschryver
Copy link
Member Author

You're right @kentcdodds .
Both approaches aren't making the linter happy, let's wait on @eps1lon to see which approach he likes more.
Personally, I think this approach is more clean than the first attempt.

timdeschryver
timdeschryver commented Jul 2, 2020
View reviewed changes
types/tslint.json
@@ -3,6 +3,7 @@
"rules": {
"no-useless-files": false,
"no-relative-import-in-test": false,
"semicolon": false
"semicolon": false,
"whitespace": false
Copy link
Member Author

@timdeschryver timdeschryver Jul 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled whitespace checks because this clashes with our prettier configuration.

@timdeschryver
Copy link
Member Author

Should be good to go on my end, can you have another look at it @eps1lon and share your thoughts?

@eps1lon eps1lon merged commit 9ae9244 into master Jul 2, 2020
@eps1lon eps1lon deleted the pr/allowedroles-getbyrole branch July 2, 2020 10:05
@eps1lon
Copy link
Member

eps1lon commented Jul 2, 2020

@timdeschryver Nice work!

@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sandersn sandersn mentioned this pull request Jul 2, 2020
Closed
@timdeschryver timdeschryver mentioned this pull request Jul 7, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds

@eps1lon eps1lon

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intellisense with getByRole
3 participants
@timdeschryver @kentcdodds @eps1lon