Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklisting IPs in Network's Config #1354

Open
3 tasks
Bidon15 opened this issue Jun 13, 2022 · 3 comments
Open
3 tasks

Blacklisting IPs in Network's Config #1354

Bidon15 opened this issue Jun 13, 2022 · 3 comments
Labels
hint/needs-triage Hint: Needs Triage

Comments

@Bidon15
Copy link
Member

Bidon15 commented Jun 13, 2022

Description

Thanks to networking service we can set params(e.g. latency, jitter, packet loss) to testable instances. Still, it will be beneficial to implement the blacklist functionality.

Or if there is the other way around with link shaping, then adding a documentation description on this will be highly appreciated 🙏

What defines this endeavour to be complete?

  • Implement blacklist functionality in Network.Config struct for go-sdk
  • A simple documentation guide on godoc is already highly appreciated
  • Going Above and Beyond 🥇 : Update the docs page with blacklisting
@laurentsenta
Copy link
Contributor

Thanks for opening this issue @Bidon15, could you describe the problem you would like to solve here? And what the feature would look like?

@laurentsenta laurentsenta added the hint/needs-author-input Hint: Needs Author Input label Jun 20, 2022
@Bidon15
Copy link
Member Author

Bidon15 commented Jun 24, 2022

Thanks for the reply @laurentsenta 👍
Let's say I have 90 IPs assigned to 90 instances. And 90 instances are divided into 3 groups(thanks to composition) -> A, B, C

Problem/Issue: How can I set all instances from group C to not listen to all addresses(cut received packages from those IP range) from group A?

The feature could look something like this:

config := network.Config{
    // Usual stuff 
    
    // Set the traffic shaping characteristics.
    Default: network.LinkShape{
        // This is what is needed(range on IPs in slices) or
        // can be just a simple from -> to range
        Blacklist: []net.IP
    },

}

Please let me know if more details is needed

@laurentsenta laurentsenta added hint/needs-triage Hint: Needs Triage and removed hint/needs-author-input Hint: Needs Author Input labels Jun 28, 2022
@laurentsenta
Copy link
Contributor

Looks great, thanks for sharing more details,
might be related to #1299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hint/needs-triage Hint: Needs Triage
Projects
None yet
Development

No branches or pull requests

2 participants