New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade socket.io to 4.5.4 #1613

Open

JgJun opened this issue Dec 8, 2022 · 1 comment

JgJun commented Dec 8, 2022

testem is using "socket.io": "^4.1.2", which is using "engine.io": "~5.1.0",. engine.io@5.1.0 has vulnerable GHSA-273r-mgr4-v34f

socket.io@4.5.4 uses the fixed version engine.io@~6.2.1

The text was updated successfully, but these errors were encountered:

Member

johanneswuerbach commented Dec 9, 2022

The existing ^4.1.2 should already allow 4.5.4, but a PR doing an explicit bump is welcome :-)

https://semver.npmjs.com/

Sarveshk76 mentioned this issue

Upgraded socket.io to 4.5.4 #1751

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment