Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reporter output cruft #1464

Open
ctcpip opened this issue Jul 21, 2021 · 3 comments · May be fixed by #1463
Open

reporter output cruft #1464

ctcpip opened this issue Jul 21, 2021 · 3 comments · May be fixed by #1463

Comments

@ctcpip
Copy link

ctcpip commented Jul 21, 2021

I just upgraded from v2 to v3, and the browser log output is now in JSON.stringify() format, which for my purposes is far from ideal -- namely due to character escaping necessary of the log message.

I know I can create my own reporter, but I want 99% of what the default TAP reporter does and would really prefer not to duplicate all that code and then have to manually keep it up-to-date.

I have created a draft PR #1463 which adds a log_processor config to address this. I didn't want to do anything more extensive without consulting the project maintainer(s) on the best way to go about this, but this is working as expected. Thoughts?

Just add the config function to testem.js, for example:

  log_processor(log) {
    return log.text;
  },
@ctcpip
Copy link
Author

ctcpip commented Jun 14, 2023

@johanneswuerbach thoughts?

@johanneswuerbach
Copy link
Member

Sorry, I missed this. Adding the function seems reasonable and the PR already looks like a good start, the only thing missing would be a test to ensure we don't regress. 👍

@ctcpip
Copy link
Author

ctcpip commented May 25, 2024

@johanneswuerbach the PR is ready to go! #1463

@ctcpip ctcpip linked a pull request May 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants