Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libgconf-2-4 to Travis to get Electron running in tests #1351

Merged
merged 1 commit into from Jul 11, 2019

Conversation

astronomersiva
Copy link
Contributor

No description provided.

@stefanpenner
Copy link
Contributor

oooo, this may fix #1350

@astronomersiva astronomersiva changed the title WIP: Add libgconf-2-4 to Travis to get Electron running in tests Add libgconf-2-4 to Travis to get Electron running in tests Jul 11, 2019
@astronomersiva
Copy link
Contributor Author

Yes! The issue in #1350 is fixed by this.

Still...Sauce Labs' tests are failing with The environment you requested was unavailable. and AppVeyor seems to have a real failure:

dev mode app in interactive mode allows to restart a run:
     Uncaught TypeError: Cannot read property 'pid' of null
      at kill (lib\utils\process.js:122:33)
      at Process.onKillTimeout (lib\utils\process.js:36:5)

@stefanpenner
Copy link
Contributor

@astronomersiva this PR does seem to fix the issue that it sets out to fix. I'm going to merge, we can explore the sauce labs problem in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants