Fix standard directives being ignored in files without any rubocop reference #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreccosta
changed the title
|
I won't have access to a computer for a couple weeks. Could you add a test and fixture for this? |
|
Sure. I added a new fixture (based on the existing but with no reference to "rubocop") and respective test. |
|
Thank you for your work on this, @andreccosta. I thought I was losing it. |
|
Anything we can do to help this get merged? |
gem.add_development_dependency "standard", "1.19.1"
gem.add_development_dependency "standardrb"... until further notice. |
|
Sorry, I was computerless for the last few weeks. Looks good to merge. Thanks @andreccosta! |
|
Landed in 1.21.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.20 upgraded rubocop 1.40. That version of Rubocop contains an optimization which breaks checking for directives in files that do not have any reference to "rubocop" due to this change.
This did not trigger a fail in any test here because the fixture has a reference to "rubocop" within it. Removing it triggers this scenario.
Fixes #497.