Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we add Style/SlicingWithRange #175

Closed
searls opened this issue May 18, 2020 · 1 comment · Fixed by #252
Closed

Should we add Style/SlicingWithRange #175

searls opened this issue May 18, 2020 · 1 comment · Fixed by #252
Labels
rule change 👩‍⚖️ Suggest a style guide rule change

Comments

@searls
Copy link
Contributor

searls commented May 18, 2020

This is a new cop, check it here rubocop/rubocop#7921

Should Standard include this for 2.6 & up target versions?
@searls searls added the rule change 👩‍⚖️ Suggest a style guide rule change label May 18, 2020
@timriley
Copy link
Contributor

I like it 👍 Feels clearer, and without a cop suggesting the change, I'd forget that this is an option in the newer Rubies.

jmkoni pushed a commit that referenced this issue Jan 22, 2021
add slicing within range #175
99cc828
@jmkoni jmkoni mentioned this issue Jan 22, 2021
Merged
jmkoni pushed a commit that referenced this issue Jan 22, 2021
add slicing within range #175
a423f6a
jmkoni pushed a commit that referenced this issue Jan 25, 2021
add slicing within range #175
5ce9415
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule change 👩‍⚖️ Suggest a style guide rule change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to 1.8.1 and enable Style/SlicingWithRange standardrb/standard
2 participants
@timriley @searls