Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCUMENTATION] Website Facelift #302

Open
panayot-cankov opened this issue Sep 16, 2022 · 4 comments
Open

[DOCUMENTATION] Website Facelift #302

panayot-cankov opened this issue Sep 16, 2022 · 4 comments
Assignees
Milestone

Comments

@panayot-cankov
Copy link

I want to do some changes on the website that include:

  1. Move the docs into the main repo
    From https://github.com/testdeck/testdeck-site and https://github.com/testdeck/testdeck-jekyll-theme into the docs/ in https://github.com/testdeck/testdeck
    Hopefully this will allow features and docs to be updated simultaneously from a single PR.
  2. Make light/dark homepage themes
    Currently we roll with a light theme, but a lot of developers fancy dark. Adding some "@media preffered dark" CSS to dual style the homepage...
  3. Add some more code and a bit less text blocks on the homepage
    Currently when the homepage is opened the code block is out of sight:
@suite class TestSuite {
  @test
  someTest() {}
}
  1. Make the site a bit more mobile friendly
    Currently on a mobile phone, there are two hamburger buttons (top right, and a little lower to the left), and there is padding that shrinks the content to 4 to 5 words per line.

WIP
There is some content in the docs/ currently that will be replaced with the WIP from here:
https://github.com/testdeck/docs

A preview is available here:
https://testdeck.github.io/docs/

All the content from the existing site should be preserved except for the landing page.

@silkentrance
Copy link
Member

silkentrance commented Sep 24, 2022

@panayot-cankov since we are now using cookies to keep track of the selected test framework, we might want to inform users of the site that cookies are being used, in order to comply to current legislation?

Or can we not just get rid of the cookie and use a global variable instead?

And when we have multiple pages, we could pass the currently selected test framework as a parameter instead of keeping it as a cookie.

That way we would be clear from the requirements set forth by the GDPR and will not harass our users with forcing them to repeatedly accept these necessary cookies.

@silkentrance
Copy link
Member

silkentrance commented Sep 24, 2022

How about making the logo/test framework selection section persistent in that it will not scroll but rather stick to the top and then let users still switch between different test frameworks while walking through the existing code examples?

I see that this is currently working for portrait mobile resolutions, however, the actual content can be switched off/on by the "thing" on the left while test framework selection is still available. It does not work for desktops, though.

What about using JQuery? In addition we could also use a CSS framework, e.g. Tailwind CSS.

And we could also add in some diagrams using Mermaid JS 👍, e.g. for depicting test suite inheritance and so on.

@silkentrance
Copy link
Member

@panayot-cankov can you make this a PR based on current main?

@silkentrance
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants