Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support testcontainers/ryuk as resource reaper #577

Open
Tracked by #563
DDtKey opened this issue Apr 22, 2024 · 2 comments
Open
Tracked by #563

Support testcontainers/ryuk as resource reaper #577

DDtKey opened this issue Apr 22, 2024 · 2 comments

Comments

@DDtKey
Copy link
Collaborator

DDtKey commented Apr 22, 2024

Support https://hub.docker.com/r/testcontainers/ryuk as resource reaper, under separate feature ryuk

@DDtKey DDtKey mentioned this issue Apr 22, 2024
@mervyn-mccreight
Copy link
Contributor

We could also think about keeping watchdog for those who can't use ryuk, because of some constraints (e.g. using podman in rootless mode), or even make it the default if ryuk is not enabled. Or just provide both it behind features and the users can choose by themselves whether they want to use ryuk or watchdog.

WDYT?

@DDtKey
Copy link
Collaborator Author

DDtKey commented Apr 25, 2024

In general, I like the idea to keep both.

But I guess we need to extend watchdog to allow registration of networks (and named volumes?) to make it enabled by default. For now it works only for containers.

Anyway, I think ryuk should be implemented under separate feature ryuk, so we can keep watchdog and extend separately

@DDtKey DDtKey changed the title Support testcontainers/ryuk as resource reaper (deprecate watchdog) Support testcontainers/ryuk as resource reaper Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants