Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pausing and resuming a container #433

Open
lcmgh opened this issue Nov 8, 2022 · 6 comments
Open

Support pausing and resuming a container #433

lcmgh opened this issue Nov 8, 2022 · 6 comments

Comments

@lcmgh
Copy link

lcmgh commented Nov 8, 2022

Hi!

In my integration test I like to test my apps behavior in case the database becomes unavailable. Currently I am stopping the db but of course I also want to test the recover of the database with its former state. Even if don't mind loosing the former db state I still have to create a new db pool because port changes on every container spawn and the already injected one can never recover.

Two options come to my mind to solve the issue:

  1. Allow defining an explicit mapped host port
  2. Allow to pause and continue container without changing the mapped host port (my preferred option)

Thanks

@DDtKey
Copy link
Collaborator

DDtKey commented Nov 25, 2022

Are you (probably) looking for adding docker's pause/unpause to testcontainers api?

@thomaseizinger
Copy link
Collaborator

thomaseizinger commented Mar 10, 2023

I have never heard of docker pause but it seems like a reasonable thing to implement so I am gonna accept a PR that adds a pause and unpause API to Container and ContainerAsync.

@FibreFoX
Copy link

Stupid question: wouldn't it make more sense to just use stop and start instead of introducing a new pause/unpause, to have it more "in line" with the Java implementation like documented on the website https://www.testcontainers.org/test_framework_integration/manual_lifecycle_control/?

I think it feels "more natural" when having both ecosystems (Rust + Java) using the same method language.

@DDtKey
Copy link
Collaborator

DDtKey commented Mar 22, 2023

Hi @FibreFoX, I'll try to answer

stop + start recreates container (with graceful shutdown logic by sigterm signal or sigkill in case of hanging), so the state of such container will be dropped. For in-memory databases it's critical.

While pause/unpause doesn't.
One more case is introducing some controlled delays.

Just a different behavior and could be useful for testing purposes.

Anyway, it's official docker API for suspending processes. And I don't think we should avoid this for aligning APIs.

@FibreFoX
Copy link

@DDtKey Thanks for clarification, I wasn't aware that stop + start actually recreate the containers instead just stopping and re-starting the container. And sure, this is a very special scenario.

If I understand correct, the testcontainers-java should have an open issue to feature-request this too, right?

@mervyn-mccreight
Copy link
Contributor

One more case is introducing some controlled delays.

You could also use toxiproxy for this. I used this in some JVM project a while ago for testing (I used the java module there) and IMO it was pretty neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants