Skip to content

Add MinIO image #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Add MinIO image #334

merged 1 commit into from
Mar 9, 2022

Conversation

DDtKey
Copy link
Collaborator

@DDtKey DDtKey commented Feb 17, 2022

I think it should be pretty useful to have a S3-compatible default image.

Features:

  • Specify server args via MinIOServerArgs

In addition, one test case was added.

Copy link
Collaborator

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments.

@DDtKey
Copy link
Collaborator Author

DDtKey commented Feb 24, 2022

I've updated PR and fixed MSRV + style warnings. Thanks!

@thomaseizinger
Copy link
Collaborator

I've updated PR and fixed MSRV + style warnings. Thanks!

Sorry for the late reply!
Do you mind squashing all commits into one please?

After that, feel free to merge the PR. I'll delegate permissions now so that I don't have to come back to it. Trusting you that you will squash first ;)

bors d=DDtKey

@bors
Copy link
Contributor

bors bot commented Mar 9, 2022

✌️ DDtKey can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@DDtKey
Copy link
Collaborator Author

DDtKey commented Mar 9, 2022

Sure!
I've squashed the commits. Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 9, 2022

Build succeeded:

@bors bors bot merged commit 8d937a8 into testcontainers:dev Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants