Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of the crate #2

Open
4 of 6 tasks
DDtKey opened this issue Jun 19, 2023 · 5 comments
Open
4 of 6 tasks

Improve documentation of the crate #2

DDtKey opened this issue Jun 19, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DDtKey
Copy link
Contributor

DDtKey commented Jun 19, 2023

We need to enrich the crate with documentation

Depends on #1

Tasks

@DDtKey DDtKey added the documentation Improvements or additions to documentation label Jun 19, 2023
@DDtKey DDtKey added this to the 0.14.0 milestone Jun 19, 2023
@DDtKey DDtKey changed the title Add documentation to the crate Improve documentation of the crate Jun 19, 2023
DDtKey added a commit that referenced this issue Sep 25, 2023
DDtKey added a commit that referenced this issue Sep 25, 2023
DDtKey added a commit that referenced this issue Sep 25, 2023
@DDtKey DDtKey removed this from the 0.1.0 milestone Sep 25, 2023
DDtKey added a commit that referenced this issue Oct 20, 2023
Also removes unnecessary test

Relates to #2
@DDtKey DDtKey added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 8, 2024
@ghost
Copy link

ghost commented Jan 9, 2024

Anything I can do to help?

@DDtKey
Copy link
Contributor Author

DDtKey commented Jan 10, 2024

Two remaining tasks are:

  • Document usage of each existing module
    We have a number of modules which has been moved from testcontainers repo, most of them don't have a documentation. Need to actualize and write a documentation like this:

    /// Module to work with [`RabbitMQ`] inside of tests.
    ///
    /// Starts an instance of RabbitMQ with the [`management-plugin`] started by default,
    /// so you are able to use the [`RabbitMQ Management HTTP API`] to manage the configuration if the started [`RabbitMQ`] instance at test runtime.
    ///
    /// This module is based on the official [`RabbitMQ docker image`].
    ///
    /// # Example
    /// ```
    /// use testcontainers::clients;
    /// use testcontainers_modules::rabbitmq;
    ///
    /// let docker = clients::Cli::default();
    /// let rabbitmq_instance = docker.run(rabbitmq::RabbitMq);
    ///
    /// let amqp_url = format!("amqp://127.0.0.1:{}", rabbitmq_instance.get_host_port_ipv4(5672));
    ///
    /// // do something with the started rabbitmq instance..
    /// ```
    ///
    /// [`RabbitMQ`]: https://www.rabbitmq.com/
    /// [`management-plugin`]: https://www.rabbitmq.com/management.html
    /// [`RabbitMQ Management HTTP API`]: https://www.rabbitmq.com/management.html#http-api
    /// [`RabbitMQ docker image`]: https://hub.docker.com/_/rabbitmq

  • Contribution guide

I would be glad for any help

@ghost
Copy link

ghost commented Jan 13, 2024

Okay I'll have a go at adding documentation for the use of each module and submit a PR.

@ubiratansoares
Copy link
Contributor

@DDtKey Is there anyone assigned to Contribution Guidelines? If not, I'd love helping with that! 🙂

@DDtKey
Copy link
Contributor Author

DDtKey commented Apr 14, 2024

No, feel free to take on this task!
Thank you!🙏

DDtKey added a commit that referenced this issue Apr 18, 2024
Contributes to #2 

Adds some general contribution guidelins for this project. I've used
some other testcontainers projects (`java`, `ruby`, `python`, `rust`) as
reference.

---------

Co-authored-by: Artem Medvedev <i@ddtkey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants