Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party dependency for etcd testing #112

Open
kdmkone opened this issue Apr 3, 2024 · 1 comment
Open

Third-party dependency for etcd testing #112

kdmkone opened this issue Apr 3, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@kdmkone
Copy link

kdmkone commented Apr 3, 2024

Feature request description

Hi, I have a working implementation of an Etcd container, but in order to test it, the appropriate crate that would be required is https://github.com/etcdv3/etcd-client

The issue here is that this crate requires protobuf as an OS dependency, which might break the CI environment or some users workflow. There are other libraries that could do the trick, but those are less popular.

Any advice on the desired way to proceed is appreciated.

Image reference

No response

@kdmkone kdmkone added the enhancement New feature or request label Apr 3, 2024
@DDtKey
Copy link
Contributor

DDtKey commented Apr 5, 2024

Since this is only for testing, we can easily specify this as a prerequisite for running tests (contributing guide #1?) and update our CI. This will not affect users of the modules in any way. But only contributors.

In addition, we can consider to use just for testing (with check of prerequisites) and linting (fmt, clippy)

However, we can choose the easier way to test too, because we need to ensure that container is started and operating properly(healthy).
I mean even less popular client may work if it's alive.
This way we will avoid extra requirements for contributors.

So I'd try to avoid extra complicated deps if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants