Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azurite module #234

Merged
merged 7 commits into from Sep 21, 2022
Merged

Add azurite module #234

merged 7 commits into from Sep 21, 2022

Conversation

pffijt
Copy link
Collaborator

@pffijt pffijt commented Aug 22, 2022

Pull request to add azurite module. https://hub.docker.com/_/microsoft-azure-storage-azurite

@pffijt
Copy link
Collaborator Author

pffijt commented Aug 30, 2022

This PR is ready for review @tillahoffmann @SergeyPirogov

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #234 (fffc733) into master (f899846) will decrease coverage by 0.12%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   86.05%   85.93%   -0.13%     
==========================================
  Files          27       28       +1     
  Lines         746      782      +36     
  Branches       70       77       +7     
==========================================
+ Hits          642      672      +30     
- Misses         80       81       +1     
- Partials       24       29       +5     
Impacted Files Coverage Δ
testcontainers/azurite.py 83.33% <83.33%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

testcontainers/azurite.py Show resolved Hide resolved
testcontainers/azurite.py Outdated Show resolved Hide resolved
testcontainers/azurite.py Outdated Show resolved Hide resolved
@pffijt
Copy link
Collaborator Author

pffijt commented Sep 1, 2022

@tillahoffmann let me know if i can help you out with understanding the pr.

@dennisrei
Copy link

@SergeyPirogov @tillahoffmann can you take another look at this PR. I would like to use it in a project

@tillahoffmann tillahoffmann merged commit 99f4615 into testcontainers:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants