Catch and retry DockerClient.port() #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er.get_exposed_port) after container start. Wrap DockerContainer.get_exposed_port in wait_container_is_ready() and change DockerClient.port to raise ConnectionError so that it can be caught and retried.
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 86.56% 86.60% +0.03%
==========================================
Files 27 27
Lines 722 724 +2
Branches 65 65
==========================================
+ Hits 625 627 +2
Misses 76 76
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. |
tillahoffmann
approved these changes
Aug 6, 2022
|
I ran into this issue on my enviromnent, any plans to release this fix? |
|
Should be done in 3.6.1 once the upload finishes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DockerClient.port() fails when called too quickly (from DockerContainer.get_exposed_port) after container start. Wrap DockerContainer.get_exposed_port in wait_container_is_ready() and change DockerClient.port to raise ConnectionError so that it can be caught and retried.