Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to HealthCheckWaitStrategy for containers with health checks defined #687

Open
jalaziz opened this issue Dec 7, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jalaziz
Copy link

jalaziz commented Dec 7, 2023

Expected Behaviour

For containers or compose services with health checks defined, the default wait strategy should be the HealthCheckWaitStrategy.

This would be particularly useful for compose projects where many services can be defined and health checks can be defined directly in the compose config.

Actual Behaviour

The default wait strategy is the HostPortWaitStrategy which is not always applicable. While we can override the health check manually, it would be great if testcontainers could automatically use the best strategy.

Testcontainer Logs
...

Environment Information

  • Operating System: Ubuntu 22.04
  • Docker Version: 24.0.7
  • Node version: 18.18.2
  • Testcontainers version: 10.3.2
@cristianrgreco cristianrgreco added the triage Investigation required label Dec 8, 2023
@cristianrgreco cristianrgreco added enhancement New feature or request and removed triage Investigation required labels Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants