From 16ae727f335d494fdd7da8c38b47faf861f8d425 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edd=C3=BA=20Mel=C3=A9ndez?= Date: Mon, 13 Jun 2022 10:38:05 -0500 Subject: [PATCH] [LocalStack] Deprecate methods using aws sdk v1 Currently, `LocalStackContainer` depends on aws sdk v1. We have received feedback about moving to aws sdk v2. However, we think that the class already provides the enough information to be used such as `getEndpointOverride()`, `getRegion()`, `getAccessKey()` and `getSecretKey`. So, we are deprecating `getDefaultCredentialsProvider()` and `getEndpointConfiguration` which are going to be removed in the feature and `LocalStack` module will not depend on any aws sdk. --- .../containers/localstack/LocalStackContainer.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java b/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java index d37c80d06fa..f3f905b84f6 100644 --- a/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java +++ b/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java @@ -193,7 +193,9 @@ public LocalStackContainer withServices(EnabledService... services) { * * @param service the service that is to be accessed * @return an {@link AwsClientBuilder.EndpointConfiguration} + * @deprecated {@link LocalStackContainer} will not depend on aws sdk. */ + @Deprecated public AwsClientBuilder.EndpointConfiguration getEndpointConfiguration(Service service) { return new AwsClientBuilder.EndpointConfiguration(getEndpointOverride(service).toString(), getRegion()); } @@ -257,7 +259,9 @@ private int getServicePort(EnabledService service) { .build() * @return an {@link AWSCredentialsProvider} + * @deprecated {@link LocalStackContainer} will not depend on aws sdk. */ + @Deprecated public AWSCredentialsProvider getDefaultCredentialsProvider() { return new AWSStaticCredentialsProvider(new BasicAWSCredentials(getAccessKey(), getSecretKey())); }