Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary start() call in initCouchbaseContainer() method #877

Merged
merged 1 commit into from
Sep 23, 2018
Merged

Remove unnecessary start() call in initCouchbaseContainer() method #877

merged 1 commit into from
Sep 23, 2018
+0 −1

Conversation

kiview
Copy link
Member

@kiview kiview commented Sep 23, 2018

Seems the wrong place, since the containers themselves are annotated with @ClassRule in the tests.

@bsideup bsideup added this to the next milestone Sep 23, 2018
@kiview kiview merged commit 2307b79 into master Sep 23, 2018
@kiview kiview deleted the fix-flaky-couchbase-tests branch September 23, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@bsideup bsideup bsideup approved these changes

Assignees
No one assigned
Labels
type/test-improvement
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiview @rnorth @bsideup