Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pulsar to 2.1.1 #874

Merged
merged 1 commit into from
Sep 23, 2018
Merged

Update Pulsar to 2.1.1 #874

merged 1 commit into from
Sep 23, 2018

Conversation

haphut
Copy link
Contributor

@haphut haphut commented Sep 22, 2018

No description provided.

@kiview
Copy link
Member

kiview commented Sep 22, 2018 •
edited

I've re-triggered the build, fail seemed unrelated.

LGTM, but I wonder what's our general strategy keeping the default version of our custom containers up do date, by this possibly breaking tests of users.
What's our take on this @rnorth @bsideup ?

@bsideup bsideup added this to the next milestone Sep 23, 2018
@bsideup
Copy link
Member

bsideup commented Sep 23, 2018

Looks good. Thanks @haphut for keeping it up-to-date 👍

@kiview I think it's ok to update, especially build versions. We do provide a way to fix the version for the ones who want to be strict, so it's fine :)

@bsideup bsideup merged commit c0f596a into testcontainers:master Sep 23, 2018
@haphut haphut deleted the update-pulsar branch September 24, 2018 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haphut @kiview @bsideup