Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Netty classes from OkHttpInvocationBuilder #869

Merged
merged 4 commits into from
Sep 20, 2018
Merged

remove Netty classes from OkHttpInvocationBuilder #869

merged 4 commits into from
Sep 20, 2018

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Sep 14, 2018

No description provided.

@bsideup bsideup added this to the next milestone Sep 14, 2018
kiview
kiview approved these changes Sep 16, 2018
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a Windows test for this? 😸

.../src/main/java/org/testcontainers/dockerclient/transport/okhttp/OkHttpInvocationBuilder.java Show resolved Hide resolved
@bsideup bsideup merged commit 75e0ee4 into master Sep 20, 2018
@bsideup bsideup deleted the remove_netty_from_okhttp branch September 20, 2018 20:04
@rnorth
Copy link
Member

rnorth commented Sep 21, 2018

Released for preview in 1.9.0-rc2, to be published on Bintray.

@bsideup bsideup modified the milestones: 1.9.0-rc2, 1.9.0 Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@kiview kiview kiview approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.0-rc2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bsideup @rnorth @kiview