Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Selenium/BrowserWebDriver - Get rid of your VNC recorder and use Selenium's video recorder #8575

Open
AB-xdev opened this issue Apr 24, 2024 · 1 comment

Comments

@AB-xdev
Copy link
Contributor

AB-xdev commented Apr 24, 2024

Module

Selenium

Problem

There are multiple open problems with the VNC recorder:

Additionally:

  • the recorder requires VNC
  • The VNC recording code is based on some python code from 2010 and looks outdated
  • Requires rendering after the recording -> Needs time to stop the test

Solution

Use Selenium's video recorder

We implemented this along with some additional improvements and cleanup efforts in an open source library.

Benefit

Described in https://github.com/xdev-software/testcontainers-selenium/blob/develop/README.md under "Selenium's video recorder"

Alternatives

Searched for alternatives, the above one was the easiest for implementation. Implemented it. No problems since then.

Would you like to help contributing this feature?

Reference implementation is available at https://github.com/xdev-software/testcontainers-selenium (maybe consider giving us some credit if you port it)

@eddumelendez
Copy link
Member

Hi, we have a similar request #4579. Unfortunately, we can not drop VNC recorder because it will break existing consumers. However, we can enhance the existing implementation or provide a new one with the enhancements provided in https://github.com/xdev-software/testcontainers-selenium.

PR is very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants