feat: add clickhouse r2dbc support #8434
Open
+145
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks for your contribution, @livk-cloud ! Can you please check the comments and please update the docs accordingly.
| @@ -0,0 +1,46 @@ | |||
| package org.testcontainers.containers; | |||
There was a problem hiding this comment.
Make sure it is using ClickHouseContainer from org.testcontainers.clickhouse
Suggested change
| package org.testcontainers.containers; | |
| package org.testcontainers.clickhouse; |
There was a problem hiding this comment.
@livk-cloud check this comment.
| @@ -25,9 +25,9 @@ public class ClickHouseContainer extends JdbcDatabaseContainer<ClickHouseContain | |||
|
|
|||
| private static final DockerImageName CLICKHOUSE_IMAGE_NAME = DockerImageName.parse("clickhouse/clickhouse-server"); | |||
|
|
|||
| private static final Integer HTTP_PORT = 8123; | |||
| public static final Integer HTTP_PORT = 8123; | |||
There was a problem hiding this comment.
Suggested change
| public static final Integer HTTP_PORT = 8123; | |
| static final Integer HTTP_PORT = 8123; |
|
|
||
| private static final Integer NATIVE_PORT = 9000; | ||
| public static final Integer NATIVE_PORT = 9000; |
There was a problem hiding this comment.
Suggested change
| public static final Integer NATIVE_PORT = 9000; | |
| static final Integer NATIVE_PORT = 9000; |
modules/clickhouse/build.gradle
Outdated
| testImplementation 'org.assertj:assertj-core:3.25.1' | ||
| testImplementation testFixtures(project(':r2dbc')) | ||
| testImplementation 'com.clickhouse:clickhouse-r2dbc:0.6.0' |
There was a problem hiding this comment.
according to the docs http can be chosen for a small jar, similar to clickhouse-jdbc, why was not applied here?
Suggested change
| testImplementation 'com.clickhouse:clickhouse-r2dbc:0.6.0' | |
| testRuntimeOnly 'com.clickhouse:clickhouse-r2dbc:0.6.0' |
modules/clickhouse/build.gradle
Outdated
| testImplementation 'org.assertj:assertj-core:3.25.1' | ||
| testImplementation testFixtures(project(':r2dbc')) | ||
| testImplementation 'com.clickhouse:clickhouse-r2dbc:0.6.0' | ||
| testImplementation 'com.clickhouse:clickhouse-client:0.6.0' |
There was a problem hiding this comment.
clickhouse-r2dbc brings this dependency? or should be manually imported? should it be testRuntimeOnly?
livk-cloud
force-pushed
the
feat-clickhouse-r2dbc
branch
from
09fd62c
to
febf1b2
Compare
livk-cloud
force-pushed
the
feat-clickhouse-r2dbc
branch
from
ae68ce0
to
083dcde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for ClickHouse R2dbc and adjusted the dependency coordinates of clickhouse-jdbc
Fixes #8427