Credential helpers #729
Credential helpers #729
Conversation
|
Ok, didn't expect it to fail the build, sorry. Working on it. |
|
@TheIndifferent thanks - work isn't stalled per se, but I'm very busy 😄. I'm very grateful for your input on this, and will close my original PR. |
|
Ok, so quick update: the assumption about incorrect logic there is completely wrong. I am testing with |
|
Please see the latest commit, had to reorganize the code a little bit, but now tested it with |
|
Cannot really understand why Travis build is failing, does not seem to be related. Could someone please take a look and either rebuild or point me to the actual error to fix? |
|
@TheIndifferent could be related to #731 |
|
@TheIndifferent err, no, it's actually |
|
@bsideup thank you for the pointer, fixed it, it passes now. Could you please take a look at current version of |
There was a problem hiding this comment.
I'm pretty happy with this, but I'm biased. Thank you for picking this up and making it better, @TheIndifferent.
I've put a couple of comments for minor things; I'd be happy to tweak and push to your branch if you want, and if I have permission.
@bsideup, @kiview, how would you feel about releasing this just for Linux and Mac users, and coming back to it for Windows? I'd just like to get it shipped, and it pains me to be holding it back.
| @@ -22,7 +22,10 @@ All notable changes to this project will be documented in this file. | |||
|
|
|||
| ## [1.7.2] - 2018-04-30 | |||
|
|
|||
| - Add support for private repositories using docker credential stores/helpers (fixes [\#567](https://github.com/testcontainers/testcontainers-java/issues/567)) | |||
There was a problem hiding this comment.
Please could you shift this up to the UNRELEASED section?
Also, it looks like this same line appears (more or less the same) three times - merge issue?
I think that for now we should draw a line in the sand and release this for Mac and Linux - could we say so in the changelog entry?
| */ | ||
| public AuthConfig lookupAuthConfig(DockerImageName dockerImageName) { | ||
| log.debug("Looking up auth config for image: {}", dockerImageName); | ||
|
|
There was a problem hiding this comment.
We should probably have a check here that we're not running on Windows and fall back to normal (current) behaviour.
|
@rnorth got it, I will address the comment this weekend, sorry for the delay. |
|
I have a moment now - I'll update this. |
|
I've updated and rebased on top of the 1.8.0 release. I'll let CI run but from my perspective this should be good to go. I also raised #756 so that we don't forget to resolve this for Windows users. |
|
Hi @TheIndifferent, I have merged this into master. Thanks for your help on this! |
|
@rnorth thank you for picking this up and merging! Can't wait for next release to try it out for real :) |
|
Released in 1.8.1! 🎉 Thanks for your work on this, @TheIndifferent! |
Previous PR seems to be stalled, here is the same code with the
ifcondition fix to invoke credentials helper if no credentials were found, plus merged with current master.This functionality is tested on Docker-for-Mac and works fine. Unfortunately I am not able to test it on Windows, but it would be awesome if this was included in next release (as per "release early, release often") and maybe the Windows fix will arrive later when someone will have a chance to test/fix it?
See #647 for previous discussions.