Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spock extension does not create video recordings of failed BrowserWebDriverContainer tests #631

Closed
kiview opened this issue Apr 2, 2018 · 3 comments · Fixed by #2548
Closed

Comments

@kiview
Copy link
Member

kiview commented Apr 2, 2018

BrowserWebDriverContainer leverages JUnit's failed() and succeeded() callbacks. These methods are not called if used with the Spock extension.

@bsideup
Copy link
Member

bsideup commented Apr 11, 2018

FYI in my junit5 branch I created a framework agnostic test lifecycle:
https://github.com/testcontainers/testcontainers-java/blob/junit5/core/src/main/java/org/testcontainers/lifecycle/TestLifecycleAware.java

public void afterTestBlock(TestDescription description, Optional<Throwable> throwable) {

@stale
Copy link

stale bot commented Oct 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Oct 28, 2018
@stale stale bot removed the stale label Nov 5, 2018
kiview added a commit that referenced this issue Apr 12, 2020
…on (#2548)

Initially done as part of the Hackergarten at Gr8ConfEU 2018.
Thanks to Tamer Shahin, Marcin Erdmann and Dawid Kublik for working on this!

Fixes #631.
@kiview kiview added this to the next milestone Apr 12, 2020
@rnorth
Copy link
Member

rnorth commented Apr 13, 2020

This was released in https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0 🎉

Thanks for the contribution!

quincy referenced this issue in quincy/testcontainers-java May 28, 2020
…on (testcontainers#2548)

Initially done as part of the Hackergarten at Gr8ConfEU 2018.
Thanks to Tamer Shahin, Marcin Erdmann and Dawid Kublik for working on this!

Fixes #631.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment