Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db extra connection params are only passed to the first connection in a pool #610

Closed
jeacott1 opened this issue Mar 14, 2018 · 3 comments · Fixed by #617
Closed

db extra connection params are only passed to the first connection in a pool #610

jeacott1 opened this issue Mar 14, 2018 · 3 comments · Fixed by #617

Comments

@jeacott1
Copy link

if you attempt to use a datasource url with extra params like:

jdbc:tc:postgresql://somehostname:someport/databasename?stringtype=unspecified

the stringtype=unspecified only gets assigned to the very first connection in the pool, all the rest get nothing.

here's a fix:
#609

@rnorth
Copy link
Member

rnorth commented Mar 15, 2018

Thank you @jeacott1 for this as well. Actually @manikmagar has a PR (#594) open in a similar area. I wonder if that might also help with this problem. If it doesn't I'd be keen to fix this problem in the refactored PR that Manik has put forward.

@jeacott
Copy link

jeacott commented Mar 15, 2018

well its a trivial fix, but the problem looks fixed in that pr.

@manikmagar
Copy link
Contributor

Thanks for taking look. Yes, it was fixed as a part of implementation but was unaware of this bug until I saw this comment. I have modified a test case to test the behavior and is fixed & tested with that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants