Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for flags in DatastoreEmulatorContainer #5993

Merged
merged 3 commits into from Oct 24, 2022

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Oct 15, 2022

Datastore can start with additional flags such as --consistency 1.0
which is recommended for testing.

See https://cloud.google.com/sdk/gcloud/reference/beta/emulators/datastore/start

Datastore can start with additional flags such as `--consistency 1.0`
which is recommended for testing.
@eddumelendez eddumelendez requested a review from a team as a code owner October 15, 2022 09:05
@eddumelendez eddumelendez added this to the next milestone Oct 24, 2022
@eddumelendez eddumelendez merged commit 77f71b8 into main Oct 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the datastore_support_flags branch October 24, 2022 15:23
@bennetelli
Copy link

Thanks for your PR @eddumelendez and also thanks for reviewing and merging it, @kiview :-)

@bennetelli
Copy link

one thing: why do you add comments containing methods wrapping the actual method? I first thought you missed to delete it, but these pattern is present in all of the GCP tests and in a similar way also in other tests. Looks like this is some testcontainers magic :-) Maybe you can explain it in a brief manner? Would love to learn something new :)

@kiview
Copy link
Member

kiview commented Oct 27, 2022

Hi @bennetelli 😃
These are our markers for referencing code snippets in our docs, by using https://github.com/rnorth/mkdocs-codeinclude-plugin.

@bennetelli
Copy link

@kiview @eddumelendez do you know when these changes will be released? :) looks like they are not part of the latest patch release

@kiview
Copy link
Member

kiview commented Nov 14, 2022

@bennetelli They will be part of the next testcontainers-java release, which we plan to do soon. Until then, you can always use the latest snapshot version through Jitpack 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants