Fixes wrong timestamp calculation #5988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As already noted in testcontainers#4275
eddumelendez
approved these changes
Nov 1, 2022
|
@leblonk sorry for the delay and thanks for the contribution! This is now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already noted in #4275
The docker api returns the created date in epoch seconds, not in epoch millis. This caused the max age pull policy to always pull the image, as the calculated date ended up in the 1970ies. This fixes that by parsing the date as seconds, rather than millis.
See documentation here: https://docs.docker.com/engine/api/v1.41/#tag/Image/operation/ImageList