Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return default for empty environment variable #5983

Merged
merged 1 commit into from Oct 10, 2022
Merged

Return default for empty environment variable #5983

merged 1 commit into from Oct 10, 2022

Conversation

roulpriya
Copy link
Contributor

Check environment variables and return default if it is empty

Fixes #5026

@roulpriya roulpriya requested a review from a team as a code owner October 10, 2022 14:40
@roulpriya
Return default for empty environment variable
7eaa4d7 
Signed-off-by: Priyambada Roul <roulpriyambada@gmail.com>
@eddumelendez
Copy link
Member

thanks for your contribution @roulpriya ! Can you run ./gradlew :testcontainers:spotlessApply, please? that would fix the build

@eddumelendez eddumelendez added this to the next milestone Oct 10, 2022
@roulpriya
Copy link
Contributor Author

@eddumelendez Yes, I've done.

@eddumelendez eddumelendez merged commit 914769f into testcontainers:main Oct 10, 2022
@eddumelendez
Copy link
Member

eddumelendez commented Oct 10, 2022 •
edited by kiview

thank you so much @roulpriya ! this is now merged in main branch.

@roulpriya
Copy link
Contributor Author

Thankyou @eddumelendez
Looking forward to contributing more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17.6
Development

Successfully merging this pull request may close these issues.

'EnvironmentAndSystemPropertyClientProviderStrategy' should handle empty DOCKER_HOST
2 participants
@roulpriya @eddumelendez