Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test container example for ImmuDB #5860

Merged
merged 6 commits into from Sep 30, 2022

Conversation

hariohmprasath
Copy link
Contributor

Description of the change:

Added an example for running tests using ImmuDB database using testcontainers. Tests performs all the basic operations performed on the ImmuDB #5594

We already have a ask for this example, so contributed the same using this pull request:
#5594

Test container example using ImmuDB, performing basic operations testcontainers#5594

testcontainers#5594
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @hariohmprasath ! Few notes, ImmuDbClient and ImmuDbClientImpl can be removed and the client can be used directly in the test class. Also, add the example here

examples/immudb/src/test/java/ImmuDbTest.java Outdated Show resolved Hide resolved
Comment on lines 68 to 70
/**
* Test method for the getValue.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the javadoc for test methods

examples/immudb/src/test/java/ImmuDbTest.java Outdated Show resolved Hide resolved
examples/immudb/build.gradle Outdated Show resolved Hide resolved
@hariohmprasath
Copy link
Contributor Author

thanks for the PR @hariohmprasath ! Few notes, ImmuDbClient and ImmuDbClientImpl can be removed and the client can be used directly in the test class. Also, add the example here

Thanks @eddumelendez for the review. I have addressed all the feedback, let me know if you any suggestions. Thanks

@eddumelendez
Copy link
Member

Add the example here, please.

@hariohmprasath
Copy link
Contributor Author

Add the example here, please.

Sorry about missing that in my previous commit. I have updated now, so we should good. Thanks


// Test container for the ImmuDb database, with the latest version of the image and exposed port
@ClassRule
public static final GenericContainer<?> immuDbContainer = new GenericContainer<>("codenotary/immudb:latest")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last one... do not use latest :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, updated the image tag to 1.3

@eddumelendez eddumelendez mentioned this pull request Sep 29, 2022
17 tasks
@eddumelendez eddumelendez added this to the next milestone Sep 30, 2022
@eddumelendez eddumelendez merged commit e2aeb68 into testcontainers:main Sep 30, 2022
@eddumelendez
Copy link
Member

Thanks for your contribution, @hariohmprasath ! This is not in main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants