Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove thundra from ci.yml #5850

Merged
merged 2 commits into from Sep 17, 2022
Merged

Remove thundra from ci.yml #5850

merged 2 commits into from Sep 17, 2022

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Sep 16, 2022 •
edited

Using thundra breaks the gradle cache in master branch.

@eddumelendez
Add ci with no thundra integration
613f26d 
Debugging issues with gradle cache and see how it performs in order
to compare.
@eddumelendez eddumelendez requested a review from a team as a code owner September 16, 2022 22:17
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Sep 16, 2022
@eddumelendez
Copy link
Member Author

eddumelendez commented Sep 16, 2022 •
edited

gradle cache is used when sending a PR but not in master branch. thundra-io/thundra-gradle-test-action is only used in master branch

See this PR execution which only updates some issues templates and as expected gradle cache is used and Thundra Gradle Test Instrumentation step is skipped because of the following config. However, in master branch Thundra Gradle Test Instrumentation step is used and gradle cache is not used. See master execution here.

@eddumelendez eddumelendez changed the title Add ci with no thundra integration Remove thundra from ci.yml Sep 17, 2022
@eddumelendez eddumelendez added this to the next milestone Sep 17, 2022
@eddumelendez eddumelendez merged commit 22aa85d into master Sep 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the ci_no_thundra branch September 17, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
1.17.4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eddumelendez