couchbase: allow to configure bucket replicas and default to 0. #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
approved these changes
Sep 13, 2022
dnault
reviewed
Sep 13, 2022
| @@ -47,7 +69,7 @@ public BucketDefinition withFlushEnabled(final boolean flushEnabled) { | |||
| /** | |||
| * Sets a custom bucket quota (100MB by default). | |||
| * | |||
| * @param quota the quota to set for the bucket. | |||
| * @param quota the quota to set for the bucket in megabytes. | |||
There was a problem hiding this comment.
NIT: The quote is in mebibytes (MiB)
dnault
approved these changes
Sep 13, 2022
|
Hey @kralphs -- is this something you'd like to add to your Couchbase module for testcontainers-node? |
This change allows the user to configure the number of bucket replicas and defaults it to 0 since most of the time the user ever only needs no replicas since it is a single container. Note: technically this is a behavioral change since before the number of replicas was 1 (if not defined) but this causes issues when testing transactions (as seen in testcontainers#5835). Fixes testcontainers#5835
|
Minor fixup, replaced megabytes with mebibytes per review. @eddumelendez this should be good to go now then. |
kiview
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to configure the number of bucket replicas and defaults it to 0 since most of the time the user ever only needs no replicas since it is a single container.
Note: technically this is a behavioral change since before the number of replicas was 1 (if not defined) but this causes issues when testing transactions (as seen in #5835).
Fixes #5835