Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ContainerDatabaseDriver does not register Properties object #5829

Merged
merged 5 commits into from Sep 26, 2022
Merged

fix: ContainerDatabaseDriver does not register Properties object #5829

merged 5 commits into from Sep 26, 2022

Conversation

aidando73
Copy link
Contributor

Fixes #5622

@aidando73 aidando73 requested a review from a team as a code owner September 8, 2022 12:35
eddumelendez
eddumelendez reviewed Sep 8, 2022
View reviewed changes
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks once again for the pR @REslim30 ! I left tiny comments

modules/jdbc/build.gradle Outdated Show resolved Hide resolved
modules/jdbc/src/test/java/org/testcontainers/jdbc/MissingJdbcDriverTest.java Outdated Show resolved Hide resolved
modules/jdbc/src/test/java/org/testcontainers/jdbc/ContainerDatabaseDriverTest.java Outdated Show resolved Hide resolved
aidando73 and others added 2 commits September 9, 2022 06:43
@aidando73 @eddumelendez
Use isFirst and isLast instead of next()
5b5b1ce 
Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
@aidando73
move test to own test class in mysql module
8e32f25
@aidando73
Copy link
Contributor Author

Thank you @eddumelendez for the review. I've addressed your suggestions.

@eddumelendez eddumelendez added this to the next milestone Sep 9, 2022
@kiview kiview merged commit 9847d59 into testcontainers:master Sep 26, 2022
@kiview
Copy link
Member

kiview commented Sep 26, 2022

Thanks for another great contribution @REslim30.

@aidando73
Copy link
Contributor Author

My pleasure @kiview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

@kiview kiview kiview approved these changes

Assignees
No one assigned
Labels
modules/jdbc type/enhancement
Projects
None yet
Milestone
1.17.4
Development

Successfully merging this pull request may close these issues.

[Enhancement]: ContainerDatabaseDriver ignores additional JDBC properties
3 participants
@aidando73 @kiview @eddumelendez