Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localstack images in tests #5783

Merged
merged 3 commits into from Sep 16, 2022
Merged

Update localstack images in tests #5783

merged 3 commits into from Sep 16, 2022

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Aug 29, 2022

atlassian/pipelines-awscli is deprecated and it recommends to use
amazon/aws-cli.

`atlassian/pipelines-awscli` is deprecated and it recommends to use
`amazon/aws-cli`. Also, testing against `localstack/localstack:1.0.4`.
@eddumelendez eddumelendez requested a review from a team as a code owner August 29, 2022 23:04
@kiview
Copy link
Member

kiview commented Aug 30, 2022

@eddumelendez
Copy link
Member Author

eddumelendez commented Aug 30, 2022

locally the test pass. However in CI (GHA)

    java.lang.AssertionError: [Created queue has external hostname URL] 
    Expecting actual:
      "http://127.0.0.1:49165/000000000000/baz"
    to contain:
      "http://localhost:49165" 
        at org.testcontainers.containers.localstack.LocalstackContainerTest$WithoutNetwork.sqsTestOverBridgeNetwork(LocalstackContainerTest.java:156)

I tested with different versions here and it seems that it's failing with versions we are not testing. In the repo attached it fails for 0.14.5 and 1.0.4
See logs here

@eddumelendez
Copy link
Member Author

The issue starts using 0.14.3. Just reach out localstack in slack in order to get more info about this due to it only fails in GHA. didn't find anything related by reading the release notes

@kiview
Copy link
Member

kiview commented Aug 31, 2022

I think this might be related to the config of the Docker daemon on GHA and it might even be an issue regarding the assumptions of our test. However, obviously there is also some kind of change in the image itself, that triggers this behavior.

@eddumelendez
Copy link
Member Author

in order to do not block this PR I have removed the upgrade for localstack image

@kiview kiview added this to the next milestone Sep 16, 2022
@kiview kiview added modules/localstack dependencies Pull requests that update a dependency file type/dependency update and removed dependencies Pull requests that update a dependency file labels Sep 16, 2022
@eddumelendez eddumelendez merged commit 9540652 into master Sep 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the localstack_tests branch September 16, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants