Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getContainerByServiceName should work without suffix #5776

Merged
merged 3 commits into from Aug 31, 2022
Merged

getContainerByServiceName should work without suffix #5776

merged 3 commits into from Aug 31, 2022

Conversation

aidando73
Copy link
Contributor

@aidando73 aidando73 commented Aug 27, 2022 •
edited by eddumelendez

Fixes #5773

@aidando73 aidando73 requested a review from a team as a code owner August 27, 2022 03:05
@aidando73 aidando73 changed the title getContainerByServiceName should work without sufix getContainerByServiceName should work without suffix Aug 27, 2022
@kiview
Copy link
Member

kiview commented Aug 29, 2022 •
edited

Thanks for the PR. The change makes a test in the JUnit5 fail, can you please take a look?
https://github.com/testcontainers/testcontainers-java/runs/8047450685?check_suite_focus=true#step:7:270

@aidando73
Copy link
Contributor Author

@kiview 👍, ok build is good. Think it was a flaky test.

@eddumelendez eddumelendez self-assigned this Aug 31, 2022
@eddumelendez eddumelendez added this to the next milestone Aug 31, 2022
@eddumelendez eddumelendez merged commit fc3d600 into testcontainers:master Aug 31, 2022
@eddumelendez
Copy link
Member

thank you so much for your contribution @REslim30 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddumelendez eddumelendez eddumelendez approved these changes

Assignees

@eddumelendez eddumelendez

Labels
area/docker-compose
Projects
None yet
Milestone
1.17.4
Development

Successfully merging this pull request may close these issues.

[Bug]: DockerComposeContainer.getContainerByServiceName not working as expectd
3 participants
@aidando73 @kiview @eddumelendez