Add compatibility with MongoDB 6 #5771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MongoDB 6 removed `mongo` shell and `mongosh` is recommended. See [here](https://www.mongodb.com/docs/manual/release-notes/6.0-compatibility/#legacy-mongo-shell-removed) Closes #5768
kiview
approved these changes
Aug 26, 2022
bsideup
reviewed
Aug 26, 2022
Comment on lines
+95
to
+96
| String cmd = this.isAtLeastVersion6 ? "mongosh" : "mongo"; | ||
| return new String[] { cmd, "--eval", command }; |
There was a problem hiding this comment.
@eddumelendez WDYT about not using ComparableVersion but doing "mongosh || mongo"-style command, so that the shell will "fallback" automatically?
There was a problem hiding this comment.
That sounds like a good idea, let's do a follow-up PR for this @eddumelendez and keep this in mind as a pattern when possible 👍
|
@eddumelendez (cc @loicmathieu) it would be really awesome for Quarkus users if we could get a release of test containers with Mongo 6 containers support included. Any chance of that? |
|
@luketn There will be a release very soon that will include this PR 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB 6 removed
mongoshell andmongoshis recommended.See here
Closes #5768