Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redpanda module #5740

Merged
merged 6 commits into from Aug 18, 2022
Merged

Add Redpanda module #5740

merged 6 commits into from Aug 18, 2022

Conversation

eddumelendez
Copy link
Member

@eddumelendez eddumelendez commented Aug 18, 2022

New module uses docker.redpanda.com/vectorized/redpanda:v22.2.1 docker image as a
base giving the --mode dev-container flag added in that version.

Co-authored-by: Sergei Egorov bsideup@gmail.com

New module uses `vectorized/redpanda:v22.2.1` docker image as a
base giving the `--mode dev-container` flag added in that version.

Co-authored-by: Sergei Egorov <bsideup@gmail.com>
@eddumelendez eddumelendez requested a review from a team as a code owner August 18, 2022 19:59
@eddumelendez
Copy link
Member Author

@bsideup bsideup added this to the next milestone Aug 18, 2022
@bsideup bsideup changed the title Add redpanda module Add Redpanda module Aug 18, 2022
Copy link
Member

@bsideup bsideup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@eddumelendez eddumelendez merged commit 8b55a3e into master Aug 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the redpanda branch August 18, 2022 23:36
@kiview kiview removed the type/docs label Aug 19, 2022
@gustavomonarin
Copy link
Contributor

The current testcontainers documentation (which is awesome by the way) seems to follow a different release pipeline from library release itself, leading to an already published website that miss leads to this module to be included already in the latest_version:

testImplementation "org.testcontainers:redpanda:1.17.3"

Looking forward for the upcoming next release :)

@kiview
Copy link
Member

kiview commented Aug 24, 2022

Thanks for pointing this out @gustavomonarin. You are right, this is currently a general issue of how we publish our docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants