Make outer maximum startup timeout in DockerComposeContainer configurable
#5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henri-tremblay
force-pushed
the
allow-to-configure-maximum-timeout
branch
from
035a6ce
to
9ea6e80
Compare
eddumelendez
requested changes
Jul 25, 2022
There was a problem hiding this comment.
Thanks for the pr @henri-tremblay ! I have left some comments
core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
Outdated
Show resolved
Hide resolved
henri-tremblay
force-pushed
the
allow-to-configure-maximum-timeout
branch
from
9ea6e80
to
37c1083
Compare
eddumelendez
approved these changes
Jul 28, 2022
kiview
changed the title
DockerComposeContainer configurable
|
Thanks for your contribution @henri-tremblay 🙂 |
|
You are welcome. Thanks for merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.